PHPLIB-104: Operation classes for some commands #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| } | ||
|
|
||
| /** | ||
| * @param boolean $isCursorSupported |
There was a problem hiding this comment.
This was leftover from when the wire version check was in execute() (before I moved it to createCommand()).
jmikola
force-pushed
the
phplib-104
branch
2 times, most recently
from
00fe7eb to
eda9c3c
Compare
| */ | ||
| class Aggregate implements Executable | ||
| { | ||
| private static $wireVersionForCursor = 2; |
There was a problem hiding this comment.
Before you ask, this is the closest thing to a private constant. I'd rather not have this in the public API.
jmikola
force-pushed
the
phplib-104
branch
6 times, most recently
from
eba5c16 to
f4a450e
Compare
|
lgtm |
jmikola
changed the title
jmikola
force-pushed
the
phplib-104
branch
3 times, most recently
from
ebc4ff1 to
3cb9adc
Compare
| @@ -42,6 +46,7 @@ protected function getServerVersion(ReadPreference $readPreference = null) | |||
| $readPreference ?: new ReadPreference(ReadPreference::RP_PRIMARY) | |||
| ); | |||
|
|
|||
| $cursor->setTypeMap(array('document' => 'array')); | |||
There was a problem hiding this comment.
@derickr: This should address the error you were seeing.
jmikola
force-pushed
the
phplib-104
branch
3 times, most recently
from
7790bd3 to
6bdecdb
Compare
jmikola
changed the title
Invalid arguments and options constitute a logic error, so InvalidArgumentTypeException may be used. For runtime errors (e.g. server returned something we didn't expect), UnexpectedValueTypeException may be used.
Additionally, this changes createIndexes() to no longer allow an empty array as input. The index management spec doesn't state that empty input must be accepted, so I'm not sure why we had that behavior.
jmikola
added a commit
that referenced
this pull request
Jun 18, 2015
GromNaN
added a commit
to GromNaN/mongo-php-library
that referenced
this pull request
Sep 9, 2024
* Use BSON round-trip to normalize pipelines for comparison * Use Canonical Extended JSON * Fix $regex comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-104